Skip to content

Commit 72d19a2

Browse files
committed
fix: pin nitro <0.35 and fix missing parameter in needsUpdate
1 parent 5752bbb commit 72d19a2

4 files changed

Lines changed: 9 additions & 12 deletions

File tree

bun.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
#include <jni.h>
2-
#include <fbjni/fbjni.h>
32
#include "NitroVersionCheckOnLoad.hpp"
43

54
JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM* vm, void*) {
6-
return facebook::jni::initialize(vm, []() {
7-
margelo::nitro::nitroversioncheck::registerAllNatives();
8-
});
5+
return margelo::nitro::nitroversioncheck::initialize(vm);
96
}

package/android/src/main/java/com/margelo/nitro/nitroversioncheck/HybridVersionCheck.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class HybridVersionCheck : HybridVersionCheckSpec() {
6666
override fun needsUpdate(): Promise<Boolean> {
6767
return Promise.async {
6868
try {
69-
val latest = getLatestVersion().await()
69+
val latest = getLatestVersion(null).await()
7070
version != latest
7171
} catch (e: Exception) {
7272
throw Exception("Failed to check for updates: ${e.message}", e)

package/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,17 +155,17 @@
155155
"@types/jest": "^29.5.12",
156156
"@types/react": "^19.1.03",
157157
"jest": "^29.7.0",
158-
"nitrogen": "*",
158+
"nitrogen": "<0.35.0",
159159
"react": "19.2.0",
160160
"react-native": "0.83.0",
161-
"react-native-nitro-modules": "*",
161+
"react-native-nitro-modules": "<0.35.0",
162162
"release-it": "^19.2.4",
163163
"ts-jest": "^29.1.2",
164164
"typescript": "^5.8.3"
165165
},
166166
"peerDependencies": {
167167
"react": "*",
168168
"react-native": "*",
169-
"react-native-nitro-modules": ">=32.0"
169+
"react-native-nitro-modules": "<0.35.0"
170170
}
171171
}

0 commit comments

Comments
 (0)