Fix FFT dynamic range insufficient

james34602 · james34602 · commit c082020ae9bc · 2022-06-24T13:34:52.000+08:00
Fix it by moving gain from analysis to synthesis
diff --git a/Main/libjamesdsp/jni/jamesdsp/jdsp/Effects/eel2/nseel-compiler.c b/Main/libjamesdsp/jni/jamesdsp/jdsp/Effects/eel2/nseel-compiler.c
@@ -589,9 +589,7 @@ void STFT_DynInit(int32_t *indexFw, float *analysisWnd)
 	getAsymmetricWindow(analysisWnd, synthesisWnd, indexFw[0], ovpSmps, indexFw[5] / (float)32767);
 	// Pre-shift window function
 	for (i = 0; i < indexFw[0] - indexFw[2]; i++)
-		synthesisWnd[i] = synthesisWnd[i + indexFw[2]];
-	for (i = 0; i < indexFw[0]; i++)
-		analysisWnd[i] *= (1.0f / indexFw[0]) * 0.5f;
+		synthesisWnd[i] = synthesisWnd[i + indexFw[2]] * (1.0f / indexFw[0]) * 0.5f;
 }
 int32_t STFTCartesian(float *indexer, float *analysisWnd, float *ptr)
 {

Original file line number	Diff line number	Diff line change
`@@ -589,9 +589,7 @@ void STFT_DynInit(int32_t indexFw, float analysisWnd)`
`589`	`589`	`getAsymmetricWindow(analysisWnd, synthesisWnd, indexFw[0], ovpSmps, indexFw[5] / (float)32767);`
`590`	`590`	`// Pre-shift window function`
`591`	`591`	`for (i = 0; i < indexFw[0] - indexFw[2]; i++)`
`592`		`- synthesisWnd[i] = synthesisWnd[i + indexFw[2]];`
`593`		`- for (i = 0; i < indexFw[0]; i++)`
`594`		`- analysisWnd[i] = (1.0f / indexFw[0]) 0.5f;`
	`592`	`+ synthesisWnd[i] = synthesisWnd[i + indexFw[2]] * (1.0f / indexFw[0]) * 0.5f;`
`595`	`593`	`}`
`596`	`594`	`int32_t STFTCartesian(float indexer, float analysisWnd, float *ptr)`
`597`	`595`	`{`