fix: fixed crossfeed bs2b weak causing audio loss

Author: timschneeb

src/audio/base/DspHost.cpp

@@ -419,46 +419,27 @@ void DspHost::updateGraphicEq(DspConfig *config)
 
 void DspHost::updateCrossfeed(DspConfig* config)
 {
-    bool modeExists;
-    bool enableExists;
-    int mode = config->get<int>(DspConfig::crossfeed_mode, &modeExists);
-    int enabled = config->get<bool>(DspConfig::crossfeed_enable, &enableExists);
-
-    if(!modeExists)
-    {
-        util::warning("Crossfeed mode unset, using defaults");
-    }
-
-    if(!enableExists)
-    {
-        util::warning("Crossfeed enable switch unset, disabling crossfeed.");
-        enabled = false;
-    }
+    int mode = config->get<int>(DspConfig::crossfeed_mode);
 
-    if(mode == 99)
+    // Workaround: CrossfeedChangeMode for mode 0 (weak) leads to audio loss. so let's just do it directly like BS2B custom above
+    if(mode == 99 /* custom */ || mode == 0 /* weak */)
     {
-        bool fcutExists;
-        bool feedExists;
-        int fcut = config->get<int>(DspConfig::crossfeed_bs2b_fcut, &fcutExists);
-        int feed = config->get<int>(DspConfig::crossfeed_bs2b_feed, &feedExists);
+        int fcut = config->get<int>(DspConfig::crossfeed_bs2b_fcut);
+        int feed = config->get<int>(DspConfig::crossfeed_bs2b_feed);
 
-        if(!fcutExists)
+        // Workaround, see comment above
+        if(mode == 0)
         {
-            util::warning("Crossfeed custom fcut unset, using defaults");
-            fcut = 650;
-        }
-        if(!feedExists)
-        {
-            util::warning("Crossfeed custom feed unset, using defaults");
-            feed = 95;
+            fcut = 700;
+            feed = 65;
         }
 
         memset(&cast(this->_dsp)->advXF.bs2b, 0, sizeof(cast(this->_dsp)->advXF.bs2b));
         BS2BInit(&cast(this->_dsp)->advXF.bs2b[1], (unsigned int)cast(this->_dsp)->fs, ((unsigned int)fcut | ((unsigned int)feed << 16)));
         cast(this->_dsp)->advXF.mode = 1;
     }
     else
-    {
+    {        
        CrossfeedChangeMode(cast(this->_dsp), mode);
     }
 }