[1860745] setProxyAuthorization caused IllegalArgumentException

henryju · henryju · commit 07eb3995c2c2 · 2008-04-14T14:36:18.000Z
diff --git a/jwebunit-core/src/main/java/net/sourceforge/jwebunit/util/TestContext.java b/jwebunit-core/src/main/java/net/sourceforge/jwebunit/util/TestContext.java
@@ -118,7 +118,7 @@ public void setProxyAuthorization(String user, String passwd, String host,
         this.proxyPasswd = passwd;
         this.proxyHost = host;
         this.proxyPort = port;
-        hasProxyAuth = true;
+        hasProxyAuth = !(null == user && null == passwd);
     }
 
     /**
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
     </properties>
     <body>
         <release version="1.5" date="UNKNOW" description="The latest major release before Java 1.5 migration">
+            <action type="fix" dev="henryju" issue="1860745" due-to="Ward Bergmans">
+                setProxyAuthorization caused IllegalArgumentException with null username/password and not null host/port.
+            </action>
             <action type="add" dev="henryju" issue="1793818" due-to="Achim Huegen">
                 Added setHiddenField method to WebTestCase.
             </action>

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ public void setProxyAuthorization(String user, String passwd, String host,`
`118`	`118`	`this.proxyPasswd = passwd;`
`119`	`119`	`this.proxyHost = host;`
`120`	`120`	`this.proxyPort = port;`
`121`		`- hasProxyAuth = true;`
	`121`	`+ hasProxyAuth = !(null == user && null == passwd);`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`/**`