Skip to content

proxy protocol not compatible with tls-wrapped connections/smtps #559

@jsbucy

Description

@jsbucy

AFAICT proxy protocol #246 is not compatible with tls-wrapped connections/smtps
controller.InetMixin._create_server() installs SSLContext into the asyncio server so ssl starts immediately on new connections
so there's no chance to consume the proxy protocol header prior to ssl and the ssl stack ends up reading it instead which is invalid

one way this could work is if proxy protocol is enabled, don't install the ssl context in InetMixin and instead pass an extra bool enable_smtps to smtp.SMTP so _handle_client() will setup SSLProtocol like smtp_STARTTLS() after reading the proxy header

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions