Merge pull request #37902 from stankiewicz/error_prone_voidUsed

[ErrorProne] remove voidUsed check

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1580,8 +1580,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "StringCaseLocaleUsage",
             // DoFn methods are executed reflectively at pipeline runtime
             "UnusedMethod",
-            // Void is a valid element type of DoFn elements
-            "VoidUsed",
           ]
           disabledChecks.each {
             options.errorprone.errorproneArgs.add("-Xep:${it}:OFF")

runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java

@@ -73,6 +73,7 @@ public void processElement(ProcessContext pc) {
             .apply(
                 ParDo.of(
                     new DoFn<KV<String, Iterable<Void>>, Integer>() {
+                      @SuppressWarnings("VoidUsed")
                       @ProcessElement
                       public void processElement(ProcessContext pc) {
                         int count = 0;

runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java

@@ -44,10 +44,9 @@ public void testEncodeDecode() {
 
   @Test
   public void testNullKey() {
-    Void key = null;
     VoidCoder coder = VoidCoder.of();
 
-    ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(key, coder);
+    ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(null, coder);
     assertThat(FlinkKeyUtils.decodeKey(byteBuffer, coder), is(nullValue()));
   }
 

sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java

@@ -2615,7 +2615,7 @@ public DataSource apply(Void input) {
       return instances.computeIfAbsent(
           config.config,
           ignored -> {
-            DataSource basicSource = config.apply(input);
+            DataSource basicSource = config.apply(null);
             DataSourceConnectionFactory connectionFactory =
                 new DataSourceConnectionFactory(basicSource);
             @SuppressWarnings("nullness") // apache.commons.dbcp2 not annotated