Remove duplicate predicate result and mark FN

Author: knewbury01

cpp/common/src/codingstandards/cpp/lifetimes/CppObjects.qll

@@ -159,6 +159,9 @@ Expr getASubobjectAccessOf(Expr e) {
  *
  * For `e` this will be subobject accesses of `*e`.
  * Or for `e->x` the subobject access is `x`.
+ *
+ * This predicate is not used/tested extensively so
+ * verify it before use.
  */
 Expr getASubobjectAccessOfPointee(Expr e) {
   e.getParent() instanceof PointerDereferenceExpr and

cpp/misra/src/rules/RULE-6-8-4/MemberFunctionsRefqualified.ql

@@ -35,13 +35,8 @@ class MembersReturningObject extends MembersReturningObjectOrSubobject {
   MembersReturningObject() {
     exists(ReturnStmt r, ThisExpr t |
       r.getEnclosingFunction() = this and
-      (
-        //return `this`
-        r.getAChild() = t
-        or
-        //accesses of subobjects through the `this` pointer
-        r.getAChild() = getASubobjectAccessOf(t)
-      ) and
+      //return `this`
+      r.getAChild() = t and
       t.getActualType().stripType() = this.getDeclaringType()
     )
   }
@@ -114,6 +109,3 @@ where
   not f instanceof AppropriatelyQualified and
   not f instanceof DefaultedAssignmentOperator
 select f, "Member function is not properly ref qualified."
-// from Expr e, PointerFieldAccess p
-// where e.getParent() = p
-// select e, p, p.getTarget(), p.getQualifier(), p.getParent()

cpp/misra/test/rules/RULE-6-8-4/test.cpp

@@ -25,7 +25,7 @@ struct A {
     return this;
   }
 
-  A &getstructbad2() { return *this; } // NON_COMPLIANT
+  A &getstructbad2() { return *this; } // NON_COMPLIANT[FALSE_NEGATIVE]
 };
 
 class C {