C#: Remove SSA location overrides.

Author: aschackmull

csharp/ql/lib/semmle/code/csharp/dataflow/SSA.qll

@@ -432,9 +432,6 @@ module Ssa {
     deprecated final predicate isLiveOutRefParameterDefinition(Parameter p) {
       SsaImpl::isLiveOutRefParameterDefinition(this, p)
     }
-
-    /** Gets the location of this SSA definition. */
-    override Location getLocation() { none() }
   }
 
   /**
@@ -519,8 +516,6 @@ module Ssa {
     override Element getElement() { result = ad.getElement() }
 
     override string toString() { result = "SSA def(" + this.getSourceVariable() + ")" }
-
-    override Location getLocation() { result = ad.getLocation() }
   }
 
   /**
@@ -566,18 +561,6 @@ module Ssa {
       then result = "SSA capture def(" + this.getSourceVariable() + ")"
       else result = "SSA entry def(" + this.getSourceVariable() + ")"
     }
-
-    override Location getLocation() { result = this.getCallable().getLocation() }
-  }
-
-  private module NearestLocationInput implements NearestLocationInputSig {
-    class C = ImplicitParameterDefinition;
-
-    predicate relevantLocations(ImplicitParameterDefinition def, Location l1, Location l2) {
-      not def.getBasicBlock() instanceof EntryBasicBlock and
-      l1 = def.getParameter().getALocation() and
-      l2 = def.getBasicBlock().getLocation()
-    }
   }
 
   pragma[nomagic]
@@ -608,14 +591,6 @@ module Ssa {
     override string toString() {
       result = "SSA param(" + pragma[only_bind_out](this.getParameter()) + ")"
     }
-
-    override Location getLocation() {
-      not NearestLocation<NearestLocationInput>::nearestLocation(this, _, _) and
-      result = p.getLocation()
-      or
-      // multi-bodied method: use matching parameter location
-      NearestLocation<NearestLocationInput>::nearestLocation(this, result, _)
-    }
   }
 
   /**
@@ -649,8 +624,6 @@ module Ssa {
     }
 
     override string toString() { result = "SSA call def(" + this.getSourceVariable() + ")" }
-
-    override Location getLocation() { result = this.getCall().getLocation() }
   }
 
   /**
@@ -673,8 +646,6 @@ module Ssa {
     final Definition getQualifierDefinition() { result = q }
 
     override string toString() { result = "SSA qualifier def(" + this.getSourceVariable() + ")" }
-
-    override Location getLocation() { result = this.getQualifierDefinition().getLocation() }
   }
 
   /**
@@ -713,16 +684,6 @@ module Ssa {
     }
 
     override string toString() { result = "SSA phi(" + this.getSourceVariable() + ")" }
-
-    /*
-     * The location of a phi node is the same as the location of the first node
-     * in the basic block in which it is defined.
-     *
-     * Strictly speaking, the node is *before* the first node, but such a location
-     * does not exist in the source program.
-     */
-
-    override Location getLocation() { result = this.getBasicBlock().getFirstNode().getLocation() }
   }
 
   /**