C#: Replace Ssa::UncertainDefinition with SsaUncertainWrite.

Author: aschackmull

csharp/ql/lib/semmle/code/csharp/dataflow/SSA.qll

@@ -368,7 +368,7 @@ module Ssa {
      */
     private Definition getAPhiInputOrPriorDefinition() {
       result = this.(SsaPhiDefinition).getAnInput() or
-      result = this.(UncertainDefinition).getPriorDefinition()
+      result = this.(SsaUncertainWrite).getPriorDefinition()
     }
 
     /**
@@ -691,12 +691,14 @@ module Ssa {
   }
 
   /**
+   * DEPRECATED: Use `SsaUncertainWrite` instead.
+   *
    * An SSA definition that represents an uncertain update of the underlying
    * assignable. Either an explicit update that is uncertain (`ref` assignments
    * need not be certain), an implicit non-local update via a call, or an
    * uncertain update of the qualifier.
    */
-  class UncertainDefinition extends Definition, SsaImpl::UncertainWriteDefinition {
+  deprecated class UncertainDefinition extends Definition, SsaImpl::UncertainWriteDefinition {
     /**
      * Gets the immediately preceding definition. Since this update is uncertain,
      * the value from the preceding definition might still be valid.

csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll

@@ -897,7 +897,7 @@ private module Cached {
   }
 
   cached
-  Definition uncertainWriteDefinitionInput(UncertainWriteDefinition def) {
+  deprecated Definition uncertainWriteDefinitionInput(UncertainWriteDefinition def) {
     Impl::uncertainWriteDefinitionInput(def, result)
   }