Commit ff110b5
committed
fix(eval): plumb App through LocalEvalService to fix App.plugins bypass
Closes the loop on https://github.com/google/adk-python/issues/<TBD>:
when a project wraps its root agent in `App(root_agent=..., plugins=[...])`
and runs `adk eval`, the registered plugins (e.g.,
`BigQueryAgentAnalyticsPlugin`) now fire on every invocation just like
they do for `adk web` / `adk run`. Same applies to `App.context_cache_config`
and `App.resumability_config`, which now ride along automatically.
Changes:
* `LocalEvalService.__init__` accepts an optional `app` keyword argument
and forwards it to `_generate_inferences_from_root_agent` for each
eval case.
* `cli_tools_click.cli_eval` resolves the `App` via `get_app_or_root_agent`
and passes it to `LocalEvalService`.
* `cli_optimize` (GEPA prompt optimization) also routes through
`LocalEvalService` but currently constructs it inside `LocalEvalSampler`
with no `app` argument; bringing the optimize path under App-plugin
coverage is a separate, narrower follow-up and is intentionally not
included here.1 parent f028305 commit ff110b5
3 files changed
Lines changed: 89 additions & 2 deletions
File tree
- src/google/adk
- cli
- evaluation
- tests/unittests/evaluation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
823 | 823 | | |
824 | 824 | | |
825 | 825 | | |
| 826 | + | |
826 | 827 | | |
827 | | - | |
828 | 828 | | |
829 | 829 | | |
830 | 830 | | |
| |||
834 | 834 | | |
835 | 835 | | |
836 | 836 | | |
837 | | - | |
| 837 | + | |
838 | 838 | | |
839 | 839 | | |
840 | 840 | | |
| |||
940 | 940 | | |
941 | 941 | | |
942 | 942 | | |
| 943 | + | |
943 | 944 | | |
944 | 945 | | |
945 | 946 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
| 127 | + | |
| 128 | + | |
126 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
127 | 139 | | |
| 140 | + | |
128 | 141 | | |
129 | 142 | | |
130 | 143 | | |
| |||
491 | 504 | | |
492 | 505 | | |
493 | 506 | | |
| 507 | + | |
494 | 508 | | |
495 | 509 | | |
496 | 510 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
791 | 792 | | |
792 | 793 | | |
793 | 794 | | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
0 commit comments