Remove the code we have just for mocking

We make the constructors internal but then make sure we cave
constructors with zero arity so mocking them via e.g. Moq is
easier. With this we're making out code harder to mock, but then add
ways to add another layer of mocking easier.

We enforce this constructors for mocking in the tests, without regard
for whether they make sense or not. Often it would make a lot more sense
to expose a public constructor for types so an application can return
fake results.

Author: carlosmn

LibGit2Sharp.Tests/EqualityFixture.cs

@@ -36,16 +36,9 @@ public void EqualityHelperCanTestNullInHashCode()
 
         private class ObjectWithEquality : GitObject
         {
-            private readonly ObjectId id;
-
             public ObjectWithEquality(ObjectId id = null)
+                : base(null, id)
             {
-                this.id = id;
-            }
-
-            public override ObjectId Id
-            {
-                get { return id; }
             }
         }
     }

LibGit2Sharp.Tests/LibGit2Sharp.Tests.csproj

@@ -35,9 +35,6 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="Moq, Version=4.2.1507.118, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
-      <HintPath>..\packages\Moq.4.2.1507.0118\lib\net40\Moq.dll</HintPath>
-    </Reference>
     <Reference Include="System" />
     <Reference Include="System.Core" />
     <Reference Include="System.Xml" />
@@ -89,7 +86,6 @@
     <Compile Include="CleanFixture.cs" />
     <Compile Include="CurrentOperationFixture.cs" />
     <Compile Include="MetaFixture.cs" />
-    <Compile Include="MockingFixture.cs" />
     <Compile Include="ConfigurationFixture.cs" />
     <Compile Include="AttributesFixture.cs" />
     <Compile Include="CommitAncestorFixture.cs" />

LibGit2Sharp.Tests/MetaFixture.cs

@@ -9,7 +9,6 @@
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
 using Xunit.Extensions;
-using Moq;
 
 namespace LibGit2Sharp.Tests
 {
@@ -83,78 +82,6 @@ public void TypesInLibGit2DecoratedWithDebuggerDisplayMustFollowTheStandardImplP
             }
         }
 
-        // Related to https://github.com/libgit2/libgit2sharp/pull/185
-        [Fact]
-        public void TypesInLibGit2SharpMustBeExtensibleInATestingContext()
-        {
-            var nonTestableTypes = new Dictionary<Type, IEnumerable<string>>();
-
-            IEnumerable<Type> libGit2SharpTypes = Assembly.GetAssembly(typeof(IRepository)).GetExportedTypes()
-                .Where(t => MustBeMockable(t) && t.Namespace == typeof(IRepository).Namespace);
-
-            foreach (Type type in libGit2SharpTypes)
-            {
-                if (type.IsInterface || type.IsEnum || IsStatic(type))
-                    continue;
-
-                var nonVirtualMethodNamesForType = GetNonVirtualPublicMethodsNames(type).ToList();
-                if (nonVirtualMethodNamesForType.Any())
-                {
-                    nonTestableTypes.Add(type, nonVirtualMethodNamesForType);
-                    continue;
-                }
-
-                if (!HasEmptyPublicOrProtectedConstructor(type))
-                {
-                    nonTestableTypes.Add(type, new List<string>());
-                }
-
-                if (type.IsAbstract)
-                {
-                    continue;
-                }
-
-                try
-                {
-                    if (type.ContainsGenericParameters)
-                    {
-                        var constructType = type.MakeGenericType(Enumerable.Repeat(typeof(object), type.GetGenericArguments().Length).ToArray());
-                        Activator.CreateInstance(constructType, true);
-                    }
-                    else
-                    {
-                        Activator.CreateInstance(type, true);
-                    }
-                }
-                catch
-                {
-                    nonTestableTypes.Add(type, new List<string>());
-                }
-            }
-
-            if (nonTestableTypes.Any())
-            {
-                Assert.True(false, Environment.NewLine + BuildNonTestableTypesMessage(nonTestableTypes));
-            }
-        }
-
-        private static bool MustBeMockable(Type type)
-        {
-            if (type.IsSealed)
-            {
-                return false;
-            }
-
-            if (type.IsAbstract)
-            {
-                return !type.Assembly.GetExportedTypes()
-                            .Where(t => t.IsSubclassOf(type))
-                            .All(t => t.IsAbstract || t.IsSealed);
-            }
-
-            return true;
-        }
-
         [Fact]
         public void LibGit2SharpPublicInterfacesCoverAllPublicMembers()
         {

LibGit2Sharp.Tests/MockingFixture.cs

@@ -1,7 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="Moq" version="4.2.1507.0118" targetFramework="net40" />
-  <package id="xunit" version="1.9.2" targetFramework="net40" />
-  <package id="xunit.extensions" version="1.9.2" targetFramework="net40" />
+  <package id="xunit.abstractions" version="2.0.0" targetFramework="net40" />
   <package id="xunit.runner.visualstudio" version="2.1.0" targetFramework="net40" />
 </packages>

LibGit2Sharp.Tests/packages.config

@@ -5,12 +5,6 @@
     /// </summary>
     public class AfterRebaseStepInfo
     {
-        /// <summary>
-        /// Needed for mocking.
-        /// </summary>
-        protected AfterRebaseStepInfo()
-        { }
-
         internal AfterRebaseStepInfo(RebaseStepInfo stepInfo, Commit commit, long completedStepIndex, long totalStepCount)
         {
             StepInfo = stepInfo;

LibGit2Sharp/AfterRebaseStepInfo.cs

@@ -10,12 +10,6 @@ namespace LibGit2Sharp
     /// </summary>
     public class BeforeRebaseStepInfo
     {
-        /// <summary>
-        /// Needed for mocking.
-        /// </summary>
-        protected BeforeRebaseStepInfo()
-        { }
-
         internal BeforeRebaseStepInfo(RebaseStepInfo stepInfo, long stepIndex, long totalStepCount)
         {
             StepInfo = stepInfo;

LibGit2Sharp/BeforeRebaseStepInfo.cs

@@ -47,12 +47,6 @@ internal BlameHunk(IRepository repository, GitBlameHunk rawHunk)
             }
         }
 
-        /// <summary>
-        /// For easier mocking
-        /// </summary>
-        protected BlameHunk()
-        { }
-
         /// <summary>
         /// Determine if this hunk contains a given line.
         /// </summary>

LibGit2Sharp/BlameHunk.cs

@@ -15,11 +15,6 @@ public class BlameHunkCollection : IEnumerable<BlameHunk>
         private readonly IRepository repo;
         private readonly List<BlameHunk> hunks = new List<BlameHunk>();
 
-        /// <summary>
-        /// For easy mocking
-        /// </summary>
-        protected BlameHunkCollection() { }
-
         internal BlameHunkCollection(Repository repo, RepositorySafeHandle repoHandle, string path, BlameOptions options)
         {
             this.repo = repo;

LibGit2Sharp/BlameHunkCollection.cs

@@ -13,12 +13,6 @@ public class Blob : GitObject
         private readonly ILazy<Int64> lazySize;
         private readonly ILazy<bool> lazyIsBinary;
 
-        /// <summary>
-        /// Needed for mocking purposes.
-        /// </summary>
-        protected Blob()
-        { }
-
         internal Blob(Repository repo, ObjectId id)
             : base(repo, id)
         {