Merge pull request #597 from czurnieden/subin_check

sjaeckel · web-flow · commit ae40a87a9200 · 2026-04-20T15:01:53.000+02:00
Check size of argument
diff --git a/mp_from_sbin.c b/mp_from_sbin.c
@@ -8,6 +8,9 @@ mp_err mp_from_sbin(mp_int *a, const uint8_t *buf, size_t size)
 {
    mp_err err;
 
+   if (size == 0) {
+      return MP_VAL;
+   }
    /* read magnitude */
    if ((err = mp_from_ubin(a, buf + 1, size - 1u)) != MP_OKAY) {
       return err;

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,9 @@ mp_err mp_from_sbin(mp_int a, const uint8_t buf, size_t size)`
`8`	`8`	`{`
`9`	`9`	`mp_err err;`
`10`	`10`
	`11`	`+ if (size == 0) {`
	`12`	`+ return MP_VAL;`
	`13`	`+ }`
`11`	`14`	`/* read magnitude */`
`12`	`15`	`if ((err = mp_from_ubin(a, buf + 1, size - 1u)) != MP_OKAY) {`
`13`	`16`	`return err;`