Skip to content

Commit 6816e7c

Browse files
PR template
1 parent 5b7a623 commit 6816e7c

1 file changed

Lines changed: 35 additions & 28 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 35 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,50 @@
1-
<!--- Provide a general summary of your changes in the Title above -->
1+
ver_medium.png)][linuxserverurl]
22

3-
[linuxserverurl]: https://linuxserver.io
4-
[![linuxserver.io](https://raw.githubusercontent.com/linuxserver/docker-templates/master/linuxserver.io/img/linuxserver_medium.png)][linuxserverurl]
3+
ut. We do not need a PR -->
4+
ange for corner case functionality or plugins please look at making a Docker Mod or local script https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ -->
5+
message -->
6+
-->
7+
repository, please add your changes there if appropriate -->
58

9+
TRIBUTING.md) guideline and understand that I have made the correct modifications
610

7-
<!--- Before submitting a pull request please check the following -->
11+
>
812
9-
<!--- If this is a fix for a typo (in code, documentation, or the README) please file an issue and let us sort it out. We do not need a PR -->
10-
<!--- Ask yourself if this modification is something the whole userbase will benefit from, if this is a specific change for corner case functionality or plugins please look at making a Docker Mod or local script https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ -->
11-
<!--- That if the PR is addressing an existing issue include, closes #<issue number> , in the body of the PR commit message -->
12-
<!--- You have included links to any files / patches etc your PR may be using in the body of the PR commit message -->
13-
<!--- We maintain a changelog of major revisions to the container at the end of readme-vars.yml in the root of this repository, please add your changes there if appropriate -->
13+
## Description
1414

15+
Required: Please provide a brief description of what this pull request is trying to accomplish.
1516

16-
<!--- Coding guidelines: -->
17-
<!--- 1. Installed packages in the Dockerfiles should be in alphabetical order -->
18-
<!--- 2. Changes to Dockerfile should be replicated in Dockerfile.armhf and Dockerfile.aarch64 if applicable -->
19-
<!--- 3. Indentation style (tabs vs 4 spaces vs 1 space) should match the rest of the document -->
20-
<!--- 4. Readme is auto generated from readme-vars.yml, make your changes there -->
17+
>
2118
22-
------------------------------
19+
## Context, Consequences, & Considerations
2320

24-
- [ ] I have read the [contributing](https://github.com/linuxserver/docker-baseimage-ubuntu/blob/jammy/.github/CONTRIBUTING.md) guideline and understand that I have made the correct modifications
21+
Required: Please step through the following list, pausing at each item to consider your change in relation to the item's context.
22+
Check the box to mark that it applies, and enter your relevant notes under the item.
2523

26-
------------------------------
24+
- [ ] Security: This has security implications. This includes (but not limited to) adding users, modifying user/app permissions, network rules/policies, changing a system interconnection, or changing an authorization strategy.
25+
- [ ] This PR does not require security review. These changes are part of a project plan that has already undergone security review. The link is provided below.
26+
- [ ] This PR requires security review. Add the `security` label to this PR then request a review from the [Security Code Reviewers Team](https://github.com/orgs/civisanalytics/teams/security-code-reviewers).
2727

28-
<!--- We welcome all PR’s though this doesn’t guarantee it will be accepted. -->
28+
>
2929
30-
## Description:
31-
<!--- Describe your changes in detail -->
30+
- [ ] Execution: This change requires commands to be run outside of the normal merge.
3231

33-
## Benefits of this PR and context:
34-
<!--- Please explain why we should accept this PR. If this fixes an outstanding bug, please reference the issue # -->
32+
>
3533
36-
## How Has This Been Tested?
37-
<!--- Please describe in detail how you tested your changes. -->
38-
<!--- Include details of your testing environment, and the tests you ran to -->
39-
<!--- see how your change affects other areas of the code, etc. -->
34+
- [ ] Impact: This change may cause service interruptions.
4035

36+
>
4137
42-
## Source / References:
43-
<!--- Please include any forum posts/github links relevant to the PR -->
38+
- [ ] Testing: How did you test this change (unit tests, acceptance tests, etc.)? Did you do any manual testing?
39+
40+
>
41+
42+
- [ ] Testing: How will you confirm this change once it's merged?
43+
44+
>
45+
46+
- [ ] Documentation: Documentation to reflect this change has been added to Confluence or Zendesk.
47+
48+
>
49+
50+
- [ ] **All items of the checklist have been considered and this PR description is complete.**

0 commit comments

Comments
 (0)