Skip to content

Commit 0c34ad4

Browse files
committed
refactor: rename extractors
1 parent a027bd5 commit 0c34ad4

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const DEPENDENCY_SECTIONS = [
1313
'optionalDependencies',
1414
]
1515

16-
export class JsonExtractor implements Extractor<Node> {
16+
export class PackageJsonExtractor implements Extractor<Node> {
1717
parse = createCachedParse(parseTree)
1818

1919
getNodeRange(doc: TextDocument, node: Node) {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type CatalogEntry = Pair<Scalar<string>, Scalar<string>>
1313

1414
type CatalogEntryVisitor = (catalog: CatalogEntry) => boolean | void
1515

16-
export class YamlExtractor implements Extractor<Node> {
16+
export class PnpmWorkspaceYamlExtractor implements Extractor<Node> {
1717
parse = createCachedParse((text) => parseDocument(text).contents)
1818

1919
getNodeRange(doc: TextDocument, node: Node) {

src/index.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import {
77
} from '#constants'
88
import { defineExtension } from 'reactive-vscode'
99
import { languages } from 'vscode'
10-
import { JsonExtractor } from './extractors/json'
11-
import { YamlExtractor } from './extractors/yaml'
10+
import { PackageJsonExtractor } from './extractors/package-json'
11+
import { PnpmWorkspaceYamlExtractor } from './extractors/pnpm-workspace-yaml'
1212
import { displayName, version } from './generated-meta'
1313
import { VersionCompletionItemProvider } from './providers/completion-item/version'
1414
import { registerDiagnosticCollection } from './providers/diagnostics'
@@ -18,37 +18,37 @@ import { config, logger } from './state'
1818
export const { activate, deactivate } = defineExtension((ctx) => {
1919
logger.info(`${displayName} Activated, v${version}`)
2020

21-
const jsonExtractor = new JsonExtractor()
22-
const yamlExtractor = new YamlExtractor()
21+
const packageJsonExtractor = new PackageJsonExtractor()
22+
const pnpmWorkspaceYamlExtractor = new PnpmWorkspaceYamlExtractor()
2323

2424
ctx.subscriptions.push(
2525
languages.registerHoverProvider(
2626
{ pattern: PACKAGE_JSON_PATTERN },
27-
new NpmxHoverProvider(jsonExtractor),
27+
new NpmxHoverProvider(packageJsonExtractor),
2828
),
2929
languages.registerHoverProvider(
3030
{ pattern: PNPM_WORKSPACE_PATTERN },
31-
new NpmxHoverProvider(yamlExtractor),
31+
new NpmxHoverProvider(pnpmWorkspaceYamlExtractor),
3232
),
3333
)
3434

3535
if (config.versionCompletion !== 'off') {
3636
ctx.subscriptions.push(
3737
languages.registerCompletionItemProvider(
3838
{ pattern: PACKAGE_JSON_PATTERN },
39-
new VersionCompletionItemProvider(jsonExtractor),
39+
new VersionCompletionItemProvider(packageJsonExtractor),
4040
...VERSION_TRIGGER_CHARACTERS,
4141
),
4242
languages.registerCompletionItemProvider(
4343
{ pattern: PNPM_WORKSPACE_PATTERN },
44-
new VersionCompletionItemProvider(yamlExtractor),
44+
new VersionCompletionItemProvider(pnpmWorkspaceYamlExtractor),
4545
...VERSION_TRIGGER_CHARACTERS,
4646
),
4747
)
4848
}
4949

5050
registerDiagnosticCollection({
51-
[PACKAGE_JSON_BASENAME]: jsonExtractor,
52-
[PNPM_WORKSPACE_BASENAME]: yamlExtractor,
51+
[PACKAGE_JSON_BASENAME]: packageJsonExtractor,
52+
[PNPM_WORKSPACE_BASENAME]: pnpmWorkspaceYamlExtractor,
5353
})
5454
})

0 commit comments

Comments
 (0)