Skip to content

Commit e49da47

Browse files
committed
feat(diagnostics): add deprecated tag for deprecated package versions
1 parent 3d21233 commit e49da47

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/providers/diagnostics/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { checkDeprecation } from './rules/deprecation'
1313
import { checkReplacement } from './rules/replacement'
1414
import { checkVulnerability } from './rules/vulnerability'
1515

16-
export interface NodeDiagnosticInfo extends Pick<Diagnostic, 'message' | 'severity' | 'code'> {
16+
export interface NodeDiagnosticInfo extends Omit<Diagnostic, 'range' | 'source'> {
1717
node: ValidNode
1818
}
1919
export type DiagnosticRule = (dep: DependencyInfo, pkg: PackageInfo) => Awaitable<NodeDiagnosticInfo | undefined>
@@ -61,10 +61,8 @@ export function registerDiagnosticCollection(mapping: Record<string, Extractor |
6161
if (diagnostic) {
6262
diagnostics.push({
6363
source: displayName,
64-
message: diagnostic.message,
65-
severity: diagnostic.severity,
66-
code: diagnostic.code,
6764
range: extractor.getNodeRange(document, diagnostic.node),
65+
...diagnostic,
6866
})
6967

7068
flush()

src/providers/diagnostics/rules/deprecation.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { DiagnosticRule } from '..'
22
import { npmxPackageUrl } from '#utils/links'
33
import { extractVersion } from '#utils/package'
4-
import { DiagnosticSeverity, Uri } from 'vscode'
4+
import { DiagnosticSeverity, DiagnosticTag, Uri } from 'vscode'
55

66
export const checkDeprecation: DiagnosticRule = (dep, pkg) => {
77
const exactVersion = extractVersion(dep.version)
@@ -18,5 +18,6 @@ export const checkDeprecation: DiagnosticRule = (dep, pkg) => {
1818
value: 'deprecation',
1919
target: Uri.parse(npmxPackageUrl(dep.name, exactVersion)),
2020
},
21+
tags: [DiagnosticTag.Deprecated],
2122
}
2223
}

0 commit comments

Comments
 (0)