Apply suggestions from code review

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>

Author: 3 people

PCbuild/_remote_debugging.vcxproj

@@ -121,7 +121,7 @@
       <Project>{cf7ac3d1-e2df-41d2-bea6-1e2556cdea26}</Project>
       <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
     </ProjectReference>
-    <ProjectReference Include="python3dll.vcxproj" Condition="$(DisableGil) != 'true'">
+    <ProjectReference Include="python3dll.vcxproj">
       <Project>{885d4898-d08d-4091-9c40-c700cfe3fc5a}</Project>
       <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
     </ProjectReference>

PCbuild/pcbuild.proj

@@ -60,7 +60,7 @@
       <BuildInParallel>false</BuildInParallel>
     </Projects>
     <!-- python3.dll -->
-    <Projects Include="python3dll.vcxproj" Condition="$(DisableGil) != 'true'" />
+    <Projects Include="python3dll.vcxproj" />
     <!-- python3t.dll -->
     <Projects Include="python3tdll.vcxproj" />
     <!-- py[w].exe -->

PCbuild/python3dll.vcxproj

@@ -91,7 +91,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
-      <PreprocessorDefinitions>PYTHON_DLL_NAME="python3$(PyDebugExt)";%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>PYTHON_DLL_NAME="$(PyDllName)";%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <BufferSecurityCheck>false</BufferSecurityCheck>
     </ClCompile>
     <Link>

PCbuild/python3tdll.vcxproj

@@ -91,7 +91,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
-      <PreprocessorDefinitions>PYTHON_DLL_NAME="python3t$(PyDebugExt)";%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>PYTHON_DLL_NAME="$(PyDllName)";%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <BufferSecurityCheck>false</BufferSecurityCheck>
     </ClCompile>
     <Link>

Tools/msi/core/core_files.wxs

@@ -3,7 +3,7 @@
     <Fragment>
         <ComponentGroup Id="core_dll">
             <Component Id="python_abi3tcompat.dll" Directory="abi3t_compat" Guid="*">
-                <File Id="python_abi3tcompat.dll" Name="python$(var.MajorVersionNumber)t.dll" Source="python$(var.MajorVersionNumber)t.dll" KeyPath="yes" />
+                <File Id="python_abi3tcompat.dll" Name="python$(var.MajorVersionNumber)t.dll" KeyPath="yes" />
             </Component>
             <Component Id="python_stable.dll" Directory="InstallDirectory" Guid="*">
                 <File Id="python_stable.dll" Name="python$(var.MajorVersionNumber).dll" KeyPath="yes" />