fix: add proactive tool rejection when dialog is open#1978
Merged
Conversation
samiyac
force-pushed
the
mcp-dialog-pt3
branch
2 times, most recently
from
3010e87 to
5f9ee9d
Compare
OrKoN
reviewed
Apr 29, 2026
OrKoN
reviewed
Apr 29, 2026
samiyac
changed the title
OrKoN
reviewed
Apr 29, 2026
OrKoN
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding proactive rejection of tool execution for tools which currently get blocked due to open dialogs (related to #1069 )