Skip to content

[JAVA] use JsonTypeInfo.Id.DEDUCTION for oneOf interface#23642

Open
jpfinne wants to merge 3 commits intoOpenAPITools:masterfrom
jpfinne:feature/deduction_for_java
Open

[JAVA] use JsonTypeInfo.Id.DEDUCTION for oneOf interface#23642
jpfinne wants to merge 3 commits intoOpenAPITools:masterfrom
jpfinne:feature/deduction_for_java

Conversation

@jpfinne
Copy link
Copy Markdown
Contributor

@jpfinne jpfinne commented Apr 28, 2026

same as #20919 for java generators.

Fix #20891 (for java)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

Summary by cubic

Adds optional Jackson deduction for generated Java oneOf interfaces without discriminator mappings. This enables structure-based deserialization with @JsonTypeInfo(use = DEDUCTION) and @JsonSubTypes.

  • New Features

    • New flag useDeductionForOneOfInterfaces (works with useOneOfInterfaces) to emit @JsonTypeInfo(use = JsonTypeInfo.Id.DEDUCTION) and @JsonSubTypes on oneOf interfaces without discriminators.
    • Exposed in JavaClientCodegen CLI; documented in docs/generators/java.md and docs/generators/java-microprofile.md. Test added in JavaClientCodegenTest.
    • Added Java/deductionAnnotation.mustache and integrated it into oneof_interface.mustache.
  • Refactors

    • Centralized the option in AbstractJavaCodegen; removed the duplicated setting from SpringCodegen.

Written for commit 2311be0. Summary will update on new commits. Review in cubic

@jpfinne jpfinne marked this pull request as ready for review April 28, 2026 14:27
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@jpfinne jpfinne changed the title [JAVA] Use deduction for interface without discriminator mapping [JAVA] Use deduction for interface generated from one of without discriminator mapping Apr 29, 2026
@jpfinne jpfinne changed the title [JAVA] Use deduction for interface generated from one of without discriminator mapping [JAVA] Use deduction for interface generated from oneOf without discriminator mapping Apr 29, 2026
@jpfinne jpfinne changed the title [JAVA] Use deduction for interface generated from oneOf without discriminator mapping [JAVA] use JsonTypeInfo.Id.DEDUCTION for oneOf interface Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [JavaSpring] use JsonTypeInfo.Id.DEDUCTION for oneOf interface

1 participant