Fix inconsistent History page title when opening the History page from the sidebar.#13457
Open
TransZAllen wants to merge 1 commit intoTeamNewPipe:devfrom
Open
Fix inconsistent History page title when opening the History page from the sidebar.#13457TransZAllen wants to merge 1 commit intoTeamNewPipe:devfrom
TransZAllen wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
…idebar When the History page was opened from the sidebar, onResume() always reset the top bar title to "History", regardless of the selected sort mode. Now, show the current sort mode instead. Also the sort mode to string resource mapping is moved into StatisticSortMode, so new modes can be added without changing displaySortMode().
ShareASmile
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
displaySortMode()to show the current sort mode inonResume(), instead of always resetting the top bar title toHistoryStatisticSortMode: This avoids adding extra conditional branches, such as if-else or switch-case, indisplaySortMode()when more sort modes are introduced in the future.Before/After Screenshots/Screen Record
inconsistentevery time the page is entered.enter_history_page_from_sidebar-after_fix-reduce_size.mp4
Fixes the following issue(s)
APK testing
Tested on device:
Due diligence