Skip to content

Cleanup KeepAndroidOpen dialog code#13458

Open
Stypox wants to merge 2 commits intoTeamNewPipe:masterfrom
Stypox:minsdk-23-popup
Open

Cleanup KeepAndroidOpen dialog code#13458
Stypox wants to merge 2 commits intoTeamNewPipe:masterfrom
Stypox:minsdk-23-popup

Conversation

@Stypox
Copy link
Copy Markdown
Member

@Stypox Stypox commented Apr 29, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Adds a popup as discussed in #13438. Also cleans up the KeepAndroidOpen code a bit. This targets master because after this is merged a new release should be done, v0.28.6. I already wrote a blogpost for it, TeamNewPipe/website#434.

Before/After Screenshots/Screen Record

image

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant