Skip to content

Setup axiom logging configuration#642

Open
JoeeGrigg wants to merge 1 commit intomainfrom
axiom-logging
Open

Setup axiom logging configuration#642
JoeeGrigg wants to merge 1 commit intomainfrom
axiom-logging

Conversation

@JoeeGrigg
Copy link
Copy Markdown
Member

No description provided.

@JoeeGrigg JoeeGrigg requested a review from cmraible as a code owner March 30, 2026 14:46
@JoeeGrigg JoeeGrigg removed the request for review from cmraible March 30, 2026 14:46
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09f0bf73-1b20-4f38-818c-3fbc738d6a93

📥 Commits

Reviewing files that changed from the base of the PR and between c83eb28 and 9b7a3cc.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • .env.example
  • package.json
  • src/utils/logger-config.ts
  • test/unit/utils/logger.test.ts
✅ Files skipped from review due to trivial changes (2)
  • package.json
  • .env.example

Walkthrough

Adds optional Axiom logging support: five commented environment variables in .env.example (AXIOM_DATASET, AXIOM_TOKEN, AXIOM_ORG_ID, AXIOM_URL, AXIOM_LOG_LEVEL) and the @axiomhq/pino dependency in package.json. The logger configuration now builds a multi-target transport that always includes stdout JSON and conditionally adds an Axiom transport when AXIOM_TOKEN and AXIOM_DATASET are present; otherwise the original GCP config is returned. Two unit tests were added to verify inclusion and omission of the Axiom transport based on env vars.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose and scope of the Axiom logging setup, including why this integration is needed.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding Axiom logging configuration across environment variables, package.json, logger config, and tests.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch axiom-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

60-60: Use an exact version for consistency with other production dependencies.

All other production dependencies in this file use exact version pinning (e.g., "pino": "10.3.1"), but this dependency uses a caret range ^1.5.0. For consistency and reproducible builds, pin to the exact version.

♻️ Suggested fix
-    "@axiomhq/pino": "^1.5.0",
+    "@axiomhq/pino": "1.5.0",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 60, Update the dependency declaration for
"@axiomhq/pino" in package.json to use an exact version instead of a caret
range; locate the "@axiomhq/pino": "^1.5.0" entry and change it to the exact
pinned version string (e.g., "1.5.0") to match the other production dependencies
and ensure reproducible builds.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@package.json`:
- Line 60: Update the dependency declaration for "@axiomhq/pino" in package.json
to use an exact version instead of a caret range; locate the "@axiomhq/pino":
"^1.5.0" entry and change it to the exact pinned version string (e.g., "1.5.0")
to match the other production dependencies and ensure reproducible builds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c2b1d2fc-d7ac-4713-94a0-eb29d17ded2a

📥 Commits

Reviewing files that changed from the base of the PR and between a6d8e18 and c83eb28.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • .env.example
  • package.json
  • src/utils/logger-config.ts
  • test/unit/utils/logger.test.ts

@github-actions
Copy link
Copy Markdown

❌ Staging deployment failed (tree: b07583f2e6efc84394842126d5e6f9af70c4e2e4)

@cmraible
Copy link
Copy Markdown
Collaborator

hey @JoeeGrigg, just checking in on this one. Are you waiting on me for anything in this PR, or just haven't gotten around to testing this out properly in staging yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants