Skip to content

Update architecture filter for arm64 installer #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarithaVattikuti wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Update architecture filter for arm64 installer #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion installers/win-setup-template.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ function Get-RegistryVersionFilter {
[Parameter(Mandatory)][Int32] $MinorVersion
)

$archFilter = if ($Architecture -eq 'x86') { "32-bit" } else { "64-bit" }
# ARM64 Python installer registers as "(ARM64)" in the display name, not "(64-bit)"
$archFilter = switch ($Architecture) {
'x86' { "32-bit" }
'arm64' { "64-bit|ARM64" }
default { "64-bit" }
Comment on lines +13 to +17
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says the ARM64 installer registers as "(ARM64)" instead of "(64-bit)", but the filter intentionally matches both by using 64-bit|ARM64. Please update the comment to reflect that we're expanding the match to include ARM64 (while still matching 64-bit entries), to avoid misleading future maintainers.

Copilot uses AI. Check for mistakes.
}
Comment thread
HarithaVattikuti marked this conversation as resolved.
"Python $MajorVersion.$MinorVersion.*($archFilter)"
}

Expand Down
Loading