[GHSA-fjq5-5j5f-mvxh] Deserialization of Untrusted Data in Apache commons collections#7530
Closed
joshbressers wants to merge 2 commits intojoshbressers/advisory-improvement-7530from
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the OSV advisory for CVE-2015-7501 (Apache Commons Collections deserialization) by refining the affected-version ranges and adjusting the list of affected Maven artifacts.
Changes:
- Updated the advisory
modifiedtimestamp. - Changed affected range start points for
commons-collectionsandcommons-collections4. - Removed several additional affected Maven coordinates (ServiceMix bundles and
collections-generic) from the advisory.
Comments suppressed due to low confidence (2)
advisories/github-reviewed/2022/05/GHSA-fjq5-5j5f-mvxh/GHSA-fjq5-5j5f-mvxh.json:32
- Changing
"introduced"from"0"to"3.0"narrows the affected range and will exclude any vulnerableorg.apache.commons:commons-collectionsversions prior to3.0(the Maven artifact has pre-3.0 releases). If the intent is “all versions before 3.2.2”,introducedshould remain"0"; otherwise, please add evidence that< 3.0is not affected (and encode that explicitly).
"introduced": "3.0"
},
{
"fixed": "3.2.2"
}
advisories/github-reviewed/2022/05/GHSA-fjq5-5j5f-mvxh/GHSA-fjq5-5j5f-mvxh.json:1
- This hunk shows the
affectedarray now ends after the two Apache coordinates; the PR also removed additional Maven coordinates (e.g., ServiceMix bundle coordinates andcollections-generic). If those coordinates are still used by downstream consumers, removing them will prevent OSV-based tooling from flagging affected dependencies for those specific GAVs. If the intent is to de-scope them because they’re not actually affected, consider adding replacement affected entries with correct ranges (or otherwise retaining them) so scanners don’t lose coverage for commonly-used repackaged artifacts.
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The versions listed had overlap and didn't seem to make sense based on the data in https://issues.apache.org/jira/browse/COLLECTIONS-580