Add confirmation step for XML export#1514
Merged
isc-bsaviano merged 1 commit intointersystems-community:masterfrom Mar 18, 2025
Merged
Add confirmation step for XML export#1514isc-bsaviano merged 1 commit intointersystems-community:masterfrom
isc-bsaviano merged 1 commit intointersystems-community:masterfrom
Conversation
gjsjohnmurray
approved these changes
Mar 18, 2025
Contributor
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Looks OK to me. Maybe not ideal UI, but a simple solution that shouldn't raise objections.
isc-rsingh
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1509. Here's a screenshot of the new prompt. Let me know what you think. If we can't agree on a prompt then I suggest we close this PR and the linked issue.
