Added WaveActiveBitOrTests#487
Open
KungFuDonkey wants to merge 1 commit intollvm:mainfrom
Open
Conversation
12 tasks
Icohedron
reviewed
Dec 18, 2025
|
|
||
| # Bug https://github.com/llvm/offload-test-suite/issues/393 | ||
| # XFAIL: Metal | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| # REQUIRES: Int64 |
Contributor
|
Would you mind adding this issue to the description: |
farzonl
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Mar 10, 2026
Adds the WaveActiveBitOr intrinsic from issue #99167. This intrinsic required a bit more work than the last intrinsics that I have done. There are some peculiarities, which I verified with dxcompiler: - WaveActiveBitOr only works on uint and uint64_t, no other types are allowed - There is no 16 bit version of WaveActiveBitOr Followed the checklist: - [x] Implement WaveActiveBitOr clang builtin, - [x] Link WaveActiveBitOr clang builtin with hlsl_intrinsics.h - [x] Add sema checks for WaveActiveBitOr to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp - [x] Add codegen for WaveActiveBitOr to EmitHLSLBuiltinExpr in CGBuiltin.cpp - [x] Add codegen tests to clang/test/CodeGenHLSL/builtins/WaveActiveBitOr.hlsl - [x] Add sema tests to clang/test/SemaHLSL/BuiltIns/WaveActiveBitOr-errors.hlsl - [x] Create the int_dx_WaveActiveBitOr intrinsic in IntrinsicsDirectX.td - [x] Create the DXILOpMapping of int_dx_WaveActiveBitOr to 120 in DXIL.td - [x] Create the WaveActiveBitOr.ll and WaveActiveBitOr_errors.ll tests in llvm/test/CodeGen/DirectX/ - [x] Create the int_spv_WaveActiveBitOr intrinsic in IntrinsicsSPIRV.td - [x] In SPIRVInstructionSelector.cpp create the WaveActiveBitOr lowering and map it to int_spv_WaveActiveBitOr in SPIRVInstructionSelector::selectIntrinsic. - [x] Create SPIR-V backend test case in llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveActiveBitOr.ll offload test: llvm/offload-test-suite#487
llvm-sync Bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 10, 2026
…#165156) Adds the WaveActiveBitOr intrinsic from issue #99167. This intrinsic required a bit more work than the last intrinsics that I have done. There are some peculiarities, which I verified with dxcompiler: - WaveActiveBitOr only works on uint and uint64_t, no other types are allowed - There is no 16 bit version of WaveActiveBitOr Followed the checklist: - [x] Implement WaveActiveBitOr clang builtin, - [x] Link WaveActiveBitOr clang builtin with hlsl_intrinsics.h - [x] Add sema checks for WaveActiveBitOr to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp - [x] Add codegen for WaveActiveBitOr to EmitHLSLBuiltinExpr in CGBuiltin.cpp - [x] Add codegen tests to clang/test/CodeGenHLSL/builtins/WaveActiveBitOr.hlsl - [x] Add sema tests to clang/test/SemaHLSL/BuiltIns/WaveActiveBitOr-errors.hlsl - [x] Create the int_dx_WaveActiveBitOr intrinsic in IntrinsicsDirectX.td - [x] Create the DXILOpMapping of int_dx_WaveActiveBitOr to 120 in DXIL.td - [x] Create the WaveActiveBitOr.ll and WaveActiveBitOr_errors.ll tests in llvm/test/CodeGen/DirectX/ - [x] Create the int_spv_WaveActiveBitOr intrinsic in IntrinsicsSPIRV.td - [x] In SPIRVInstructionSelector.cpp create the WaveActiveBitOr lowering and map it to int_spv_WaveActiveBitOr in SPIRVInstructionSelector::selectIntrinsic. - [x] Create SPIR-V backend test case in llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveActiveBitOr.ll offload test: llvm/offload-test-suite#487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for WaveActiveBitOr,
These tests are only for uint32 and uint64, as uint16 and all other int types are not supported in dxil and spirv