Fix NullReferenceException in AutoCheckpointTask when AOF is disabled with AofSizeLimit configured#1742
Open
Fix NullReferenceException in AutoCheckpointTask when AOF is disabled with AofSizeLimit configured#1742
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents a startup-time misconfiguration (AofSizeLimit set while AOF is disabled) that can otherwise lead to runtime NullReferenceException failures in the AOF-size-limit auto-checkpoint background task.
Changes:
- Add startup validation that rejects
AofSizeLimitwhenEnableAOFis not enabled. - Add a configuration parsing test to ensure the invalid combination is rejected and the valid combination succeeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/host/Configuration/Options.cs | Adds config validation to fail fast when AofSizeLimit is configured but AOF is disabled. |
| test/Garnet.test/GarnetServerConfigTests.cs | Adds a test covering the new invalid/valid configuration behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
badrishc
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject invalid configuration at startup where
AofSizeLimitis set but AOF is disabled (EnableAOF = false). This prevents aNullReferenceExceptioninAutoCheckpointTaskthat occurs because AOF-related objects are never initialized when AOF is off.Changes
GarnetExceptionwhenAofSizeLimitis specified without enabling AOF.AofSizeLimitWithoutAofEnabledto verify the new validation rejects the invalid config and accepts the valid one.Fixes #1696