docs(aws): add guide for extending existing services#10924
Open
mohamedsolaiman wants to merge 1 commit intoprowler-cloud:masterfrom
Open
docs(aws): add guide for extending existing services#10924mohamedsolaiman wants to merge 1 commit intoprowler-cloud:masterfrom
mohamedsolaiman wants to merge 1 commit intoprowler-cloud:masterfrom
Conversation
Add a new documentation section to the AWS provider details page explaining how to extend an existing service with new attributes. This is a common contributor task that was previously undocumented. The guide covers: 1. Identifying missing data from AWS API calls 2. Adding new Optional fields to Pydantic resource models 3. Updating data collection methods to extract new attributes 4. Using safe dictionary access (.get()) to prevent KeyError exceptions 5. Updating service tests with new mock data Also adds a best practice note about using .get() instead of direct dictionary access for AWS API responses, which prevents scan failures when API responses don't include expected keys.
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for extending existing AWS services with new attributes. Covers identifying missing data, adding Optional fields to models, updating data collection methods, using safe .get() access, and updating tests.