feat: add phase-level latency metrics for container scans#804
Open
feat: add phase-level latency metrics for container scans#804
Conversation
This comment has been minimized.
This comment has been minimized.
9 tasks
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds per-phase latency timing to the container scan flow. Each major phase (image extraction, OS package analysis, JAR/Go/Node/PHP/Python analysis, binary detection, dep tree building) is timed with Date.now() and returned on the PluginResponse via a new optional analytics field. A companion CLI change wires these timings into CLI analytics metadata as containerPluginTimings.
Any background context you want to provide?
The container plugin has no latency visibility, this PR is to collect latency metrics and surface them in the CLI analytics.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/CN-1170
https://snyksec.atlassian.net/browse/CN-1054