chore(deps): update dependency google/cloud-logging to v2#2206
Open
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Conversation
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
product-auto-label
Bot
added
the
samples
kokoro-team
removed
the
kokoro:force-run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google/cloud-logging development dependency version in composer.json. Feedback indicates that this dependency is unused and its version bump unnecessarily restricts PHP compatibility to version 8.0+, so it is recommended to remove the require-dev block entirely.
Comment on lines
11
to
14
| }, | ||
| "require-dev": { | ||
| "google/cloud-logging": "^1.21" | ||
| "google/cloud-logging": "^2.0" | ||
| } |
There was a problem hiding this comment.
The google/cloud-logging dependency is not used in this sample's code or tests. Upgrading to version 2.0 also increases the minimum PHP requirement to 8.0, which unnecessarily restricts the sample's compatibility for users on PHP 7.x. Since the dependency is unused, the entire require-dev block should be removed.
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^1.21→^2.0Release Notes
googleapis/google-cloud-php-logging (google/cloud-logging)
v2.0.0: google/cloud-logging v2.0.0Compare Source
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.