Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/firebase_firestore/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
]
},
"require-dev": {
"google/cloud-logging": "^1.21"
"google/cloud-logging": "^2.0"
}
Comment on lines 11 to 14
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The google/cloud-logging dependency is not used in this sample's code or tests. Upgrading to version 2.0 also increases the minimum PHP requirement to 8.0, which unnecessarily restricts the sample's compatibility for users on PHP 7.x. Since the dependency is unused, the entire require-dev block should be removed.

    }

}
Loading